Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fail publish code coverage results empty code coverage #19460

Closed
wants to merge 9 commits into from
Closed

Bugfix/fail publish code coverage results empty code coverage #19460

wants to merge 9 commits into from

Conversation

FlorianAlbert
Copy link

Task name: PublishCodeCoverageResults@2

Description: The publishing of the code coverage results now only get executed when there are summary files found.

Documentation changes required: N

Added unit tests: N

Attached related issue: Y #19270

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@FlorianAlbert
Copy link
Author

@microsoft-github-policy-service agree

@FlorianAlbert FlorianAlbert marked this pull request as draft January 24, 2024 11:27
@FlorianAlbert FlorianAlbert marked this pull request as ready for review January 24, 2024 11:27
@gavintoddchurch
Copy link

gavintoddchurch commented Feb 1, 2024

Thank you for creating this. One this gets merged in this would help me a lot

@FlorianAlbert
Copy link
Author

Just waiting for someone to review it 😉

@ganeshpms
Copy link

much needed. waiting to be released.

@gavintoddchurch
Copy link

@rasunkar is the code owner on the task. Can we get this reviewed? This bug has been giving my teams issues a lot

Copy link
Contributor

@vinayakmsft vinayakmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gavintoddchurch
Copy link

Now that we have approvals what is needed to get the tests ran to merge this in?

@FlorianAlbert
Copy link
Author

@vinayakmsft Is this now obsolete due to #19568?

@FlorianAlbert
Copy link
Author

Closing this due to #19568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants