Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge generated tasks build configs to the base tasks automatically #19392

Merged
merged 11 commits into from
Jan 10, 2024

Conversation

qianz2
Copy link
Contributor

@qianz2 qianz2 commented Dec 19, 2023

Task name:

Description:
BuildConfig merge: Add a function to make.js or BuildConfigGen to 'merge' a build config into the base task.
Merge all tasks in a build config to base tasks
e.g node make.js mergeBuildConfig --config Node20_225
This will 'merge' all tasks under build config Node20_225 into base tasks.

  1. Copy generated task to base task, delete generated files in generated/Task[BuldConfig] folder and Tasks/taskname/_buildConfig/Node20_225 folder.
  2. Update versionmap
  3. Remove _buildConfigMapping section in task.json and task-loc.json
  4. Delete the section in make-option.json.
Screenshot 2024-01-09 161921

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@qianz2
Copy link
Contributor Author

qianz2 commented Dec 20, 2023

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

make.js Show resolved Hide resolved
make-util.js Outdated Show resolved Hide resolved
make-util.js Outdated Show resolved Hide resolved
@qianz2 qianz2 enabled auto-merge (squash) January 8, 2024 22:18
make-util.js Outdated Show resolved Hide resolved
@qianz2 qianz2 merged commit 1982e27 into master Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants