Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh files generated during build (Unblocks CI / courtesy push) + added validation #19310

Merged
merged 17 commits into from
Nov 22, 2023

Conversation

merlynomsft
Copy link
Contributor

@merlynomsft merlynomsft commented Nov 22, 2023

Task name: Mutiple

Description: Rebuild and add files generated during build to unblock courtesy push

Fix:
node make.js build
git add . --renormalize

Documentation changes required: (Y/N) N/A

Added unit tests: (Y/N) N/A

Attached related issue: (Y/N) N/A

Checklist:
N/A : - [ ] Task version was bumped - please check instruction how to do it
N/A: - [ ] Checked that applied changes work as expected

@merlynomsft merlynomsft force-pushed the users/merlynop/node20fix branch from c12a8d1 to 9b3a390 Compare November 22, 2023 01:37
@merlynomsft merlynomsft changed the title Refresh files generated during build (Unblocks CI / courtesy push) Refresh files generated during build (Unblocks CI / courtesy push) + added validation Nov 22, 2023
@merlynomsft merlynomsft force-pushed the users/merlynop/node20fix branch from 2ca8828 to ed3c5f0 Compare November 22, 2023 04:38
@merlynomsft merlynomsft marked this pull request as ready for review November 22, 2023 06:05
@merlynomsft merlynomsft enabled auto-merge (squash) November 22, 2023 06:15
BuildConfigGen/MakeOptionsReader.cs Show resolved Hide resolved
BuildConfigGen/MakeOptionsReader.cs Show resolved Hide resolved
BuildConfigGen/MakeOptionsReader.cs Show resolved Hide resolved
BuildConfigGen/Program.cs Show resolved Hide resolved
BuildConfigGen/Program.cs Show resolved Hide resolved
BuildConfigGen/MakeOptionsReader.cs Show resolved Hide resolved
@merlynomsft merlynomsft disabled auto-merge November 22, 2023 21:38
@merlynomsft
Copy link
Contributor Author

By-passing due to integration test difficulties due to the large # of tasks modified amplifies a low failure rate. I'll address @DergachevE 's feedback in another pr.

@merlynomsft merlynomsft merged commit 601235d into master Nov 22, 2023
8 of 9 checks passed
merlynomsft added a commit that referenced this pull request Nov 22, 2023
merlynomsft added a commit that referenced this pull request Nov 22, 2023
merlynomsft added a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants