-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh files generated during build (Unblocks CI / courtesy push) + added validation #19310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlynomsft
force-pushed
the
users/merlynop/node20fix
branch
from
November 22, 2023 01:37
c12a8d1
to
9b3a390
Compare
merlynomsft
changed the title
Refresh files generated during build (Unblocks CI / courtesy push)
Refresh files generated during build (Unblocks CI / courtesy push) + added validation
Nov 22, 2023
merlynomsft
force-pushed
the
users/merlynop/node20fix
branch
from
November 22, 2023 04:38
2ca8828
to
ed3c5f0
Compare
merlynomsft
requested review from
a team,
rvairavelu,
manolerazvan,
marianan,
FinVamp1 and
patelchandni
as code owners
November 22, 2023 06:05
manolerazvan
approved these changes
Nov 22, 2023
DergachevE
requested changes
Nov 22, 2023
By-passing due to integration test difficulties due to the large # of tasks modified amplifies a low failure rate. I'll address @DergachevE 's feedback in another pr. |
merlynomsft
added a commit
that referenced
this pull request
Nov 22, 2023
merlynomsft
added a commit
that referenced
this pull request
Nov 22, 2023
This reverts commit 152c3ed.
merlynomsft
added a commit
that referenced
this pull request
Nov 22, 2023
This reverts commit d17aac2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Mutiple
Description: Rebuild and add files generated during build to unblock courtesy push
Fix:
node make.js build
git add . --renormalize
Documentation changes required: (Y/N) N/A
Added unit tests: (Y/N) N/A
Attached related issue: (Y/N) N/A
Checklist:
N/A : - [ ] Task version was bumped - please check instruction how to do it
N/A: - [ ] Checked that applied changes work as expected