Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check msdeploy version #19170

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Check msdeploy version #19170

merged 2 commits into from
Oct 27, 2023

Conversation

onetocny
Copy link
Contributor

@onetocny onetocny commented Oct 27, 2023

Task names:

  • AzureRmWebAppDeploymentV3
  • AzureRmWebAppDeploymentV4

Description: In cases when basic authentication is turned off we need to check if the proper version of MSDeploy is installed on agent machine. If the version that supports token authentication is missing tasks should fail immediately rather than trying to run deployment.

Documentation changes required: N

Added unit tests: N

Attached related issue: link

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@onetocny onetocny marked this pull request as ready for review October 27, 2023 09:33
@onetocny onetocny requested a review from rvairavelu as a code owner October 27, 2023 09:33
Copy link
Contributor

@ViktorHavrysh ViktorHavrysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onetocny onetocny merged commit 0206ae1 into master Oct 27, 2023
8 checks passed
@onetocny onetocny deleted the users/onetocny/check_msdeploy_version branch October 27, 2023 11:49
@evertonlsouza
Copy link

I am encountering some problems when running pipelines using version 4, the message is returning, ##[error]Error: Malicious entry:

When installing version 3 the pipe works correctly

@manolerazvan
Copy link
Contributor

Kindly create a new issue in the repository, providing a detailed description of the problem and attaching logs in which the 'system.debug' environment variable is set to 'true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants