microsoft · KonstantinTyukalov · Oct 16, 2023 · Oct 13, 2023 · Oct 13, 2023 · Oct 13, 2023
@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 229,
+        "Minor": 230,
         "Patch": 0
     },
     "demands": [

@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 229,
+    "Minor": 230,
     "Patch": 0
   },
   "demands": [

@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"

@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"

@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"

@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"

@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 4,
-        "Minor": 229,
+        "Minor": 230,
         "Patch": 0
     },
     "demands": [

@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 4,
-    "Minor": 229,
+    "Minor": 230,
     "Patch": 0
   },
   "demands": [

@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 5,
-        "Minor": 229,
+        "Minor": 230,
         "Patch": 0
     },
     "demands": [

@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 5,
-    "Minor": 229,
+    "Minor": 230,
     "Patch": 0
   },
   "demands": [

diff --git a/Tasks/Common/Sanitizer/ArgumentsSanitizer.ps1 b/Tasks/Common/Sanitizer/ArgumentsSanitizer.ps1
@@ -58,9 +58,11 @@ function Get-SanitizedArguments([string]$inputArgs) {
     $argsSplitSymbols = '``';
     [string[][]]$matchesChunks = @()
 
-    # regex rule for removing symbols and telemetry.
-    # '?<!`' - checking if before character no backtick. '([allowedchars])' - checking if character is allowed. Otherwise, replace to $removedSymbolSign
-    $regex = '(?<!`)([^a-zA-Z0-9\\` _''"\-=\/:\.*,+~?%\n])';
+    ## PowerShell Regex is case insensitive by default, so we don't need to specify a-zA-Z.
+    ## ('?<!`') - checking if before character no backtick.
+    ## ([^\w` _'"-=\/:\.*,+~?%\n#]) - checking if character is allowed. Insead replacing to #removed#
+    ## (?!true|false) - checking if after characters sequence no $true or $false.
+    $regex = '(?<!`)([^\w\\` _''"\-=\/:\.*,+~?%\n#])(?!true|false)'
 
     # We're splitting by ``, removing all suspicious characters and then join
     $argsArr = $inputArgs -split $argsSplitSymbols;

diff --git a/Tasks/Common/Sanitizer/Tests/L0Protect-ScriptArguments.Passes.ps1 b/Tasks/Common/Sanitizer/Tests/L0Protect-ScriptArguments.Passes.ps1
@@ -12,23 +12,19 @@ $inputArgsSuites = @(
     "--parameter",                              # Many modern applications accept parameters with double hyphen
     "parameter=value",                          # Format for passing values to parameters
     "parameter value.txt",                      # Argument with dot in the middle
-    "-parameter",                               # Single hyphen followed by a single letter or digit (POSIX style)
     "-parameter value",                         # When the parameter needs a value
-    "--parameter",                              # Double hyphen followed by a word (GNU style)
     "--parameter=value",                        # Value directly attached to the parameter with an equals sign
-    "parameter=value",                          # Used to pass environment variables to a command
-    "parameter value.txt",                      # Argument with dot in the middle
     "-Parameter Value",                         # Most common form
     "-Parameter:Value",                         # Colon connects the parameter and its value
     "/p:Parameter=Value",                       # Specific syntax for tools like MSBuild or NuGet
     "--Parameter Value",                        # Used by cmdlets or scripts for cross-platform compatibility
     "--Parameter=Value",                        # Used by cross-platform tools
-    "parameter value.txt"                       # Argument with dot in the middle
-    'a A 1 \ ` _ '' " - = / : . * , + ~ ? %',    # Just each allowed symbol
+    'a A z Z 1 9 \ ` _ '' " - = / : . * , + ~ ? % #',      # Just each allowed symbol
     '',
     'test 1',
     'test `; whoami `&`& echo test',
-    "line 1 `n line 2"
+    "line 1 `n line 2",
+    '$TrUe $true $fAlsE $false'
 )
 
 foreach ($inputArgs in $inputArgsSuites) {

diff --git a/Tasks/Common/Sanitizer/runTests.ps1 b/Tasks/Common/Sanitizer/runTests.ps1
@@ -0,0 +1,23 @@
+## Temp script to run L0 tests for Sanitizer.
+## TODO: Remove after https://github.com/microsoft/azure-pipelines-tasks/pull/19108 will be merged.
+
+$startLoc = Get-Location
+
+$projectRoot = "$PSScriptRoot/../../.."
+Set-Location $projectRoot
+
+$buildPath = "$projectRoot/_build/Tasks/Common/Sanitizer"
+
+try {
+    Remove-Item $buildPath -Recurse -Force -ErrorAction SilentlyContinue
+
+    ## Workaround to build common package
+    node make build --task WindowsMachineFileCopyV1
+
+    Write-Host "Running L0 tests..."
+    Set-Location $buildPath/Tests
+    mocha ./L0.js
+}
+finally {
+    Set-Location $startLoc
+}
diff --git a/Tasks/Common/Sanitizer/tsconfig.json b/Tasks/Common/Sanitizer/tsconfig.json
@@ -0,0 +1,6 @@
+{
+    "compilerOptions": {
+        "target": "ES6",
+        "module": "commonjs"
+    }
+}
@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 229,
+        "Minor": 230,
         "Patch": 0
     },
     "minimumAgentVersion": "1.104.0",

@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 229,
+    "Minor": 230,
     "Patch": 0
   },
   "minimumAgentVersion": "1.104.0",

@@ -13,7 +13,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 2,
-        "Minor": 229,
+        "Minor": 230,
         "Patch": 0
     },
     "releaseNotes": "What's new in Version 2.0: <br/>&nbsp;&nbsp;Proxy support is being added. <br/>&nbsp;&nbsp; Removed support of legacy DTL machines.",

@@ -13,7 +13,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
+    "Minor": 230,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",

diff --git a/_generated/AzureFileCopyV2.versionmap.txt b/_generated/AzureFileCopyV2.versionmap.txt
@@ -1,2 +1,2 @@
-Default|2.229.1
-Node16-225|2.229.0
+Default|2.230.0
+Node16-225|2.230.1
diff --git a/_generated/AzureFileCopyV2/task.json b/_generated/AzureFileCopyV2/task.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"
@@ -370,7 +370,7 @@
     "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired."
   },
   "_buildConfigMapping": {
-    "Default": "2.229.1",
-    "Node16-225": "2.229.0"
+    "Default": "2.230.0",
+    "Node16-225": "2.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV2/task.loc.json b/_generated/AzureFileCopyV2/task.loc.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"
@@ -370,7 +370,7 @@
     "ExpiredServicePrincipal": "ms-resource:loc.messages.ExpiredServicePrincipal"
   },
   "_buildConfigMapping": {
-    "Default": "2.229.1",
-    "Node16-225": "2.229.0"
+    "Default": "2.230.0",
+    "Node16-225": "2.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV2_Node16/task.json b/_generated/AzureFileCopyV2_Node16/task.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 0
+    "Minor": 230,
+    "Patch": 1
   },
   "demands": [
     "azureps"
@@ -374,7 +374,7 @@
     "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired."
   },
   "_buildConfigMapping": {
-    "Default": "2.229.1",
-    "Node16-225": "2.229.0"
+    "Default": "2.230.0",
+    "Node16-225": "2.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV2_Node16/task.loc.json b/_generated/AzureFileCopyV2_Node16/task.loc.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 2,
-    "Minor": 229,
-    "Patch": 0
+    "Minor": 230,
+    "Patch": 1
   },
   "demands": [
     "azureps"
@@ -374,7 +374,7 @@
     "ExpiredServicePrincipal": "ms-resource:loc.messages.ExpiredServicePrincipal"
   },
   "_buildConfigMapping": {
-    "Default": "2.229.1",
-    "Node16-225": "2.229.0"
+    "Default": "2.230.0",
+    "Node16-225": "2.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV3.versionmap.txt b/_generated/AzureFileCopyV3.versionmap.txt
@@ -1,2 +1,2 @@
-Default|3.229.1
-Node16-225|3.229.0
+Default|3.230.0
+Node16-225|3.230.1
diff --git a/_generated/AzureFileCopyV3/task.json b/_generated/AzureFileCopyV3/task.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"
@@ -309,7 +309,7 @@
     "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired."
   },
   "_buildConfigMapping": {
-    "Default": "3.229.1",
-    "Node16-225": "3.229.0"
+    "Default": "3.230.0",
+    "Node16-225": "3.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV3/task.loc.json b/_generated/AzureFileCopyV3/task.loc.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 1
+    "Minor": 230,
+    "Patch": 0
   },
   "demands": [
     "azureps"
@@ -309,7 +309,7 @@
     "ExpiredServicePrincipal": "ms-resource:loc.messages.ExpiredServicePrincipal"
   },
   "_buildConfigMapping": {
-    "Default": "3.229.1",
-    "Node16-225": "3.229.0"
+    "Default": "3.230.0",
+    "Node16-225": "3.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV3_Node16/task.json b/_generated/AzureFileCopyV3_Node16/task.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 0
+    "Minor": 230,
+    "Patch": 1
   },
   "demands": [
     "azureps"
@@ -313,7 +313,7 @@
     "ExpiredServicePrincipal": "Could not fetch access token for Azure. Verify if the Service Principal used is valid and not expired."
   },
   "_buildConfigMapping": {
-    "Default": "3.229.1",
-    "Node16-225": "3.229.0"
+    "Default": "3.230.0",
+    "Node16-225": "3.230.1"
   }
 }
diff --git a/_generated/AzureFileCopyV3_Node16/task.loc.json b/_generated/AzureFileCopyV3_Node16/task.loc.json
@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 3,
-    "Minor": 229,
-    "Patch": 0
+    "Minor": 230,
+    "Patch": 1
   },
   "demands": [
     "azureps"
@@ -313,7 +313,7 @@
     "ExpiredServicePrincipal": "ms-resource:loc.messages.ExpiredServicePrincipal"
   },
   "_buildConfigMapping": {
-    "Default": "3.229.1",
-    "Node16-225": "3.229.0"
+    "Default": "3.230.0",
+    "Node16-225": "3.230.1"
   }
 }