-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 21 artifact package tasks to Node20 #19101
Conversation
"CargoAuthenticateV0", "CondaAuthenticateV0", "DownloadPackageV0", "DownloadPackageV1", "MavenAuthenticateV0", "NpmV0", "NpmV1", "NpmAuthenticateV0", "NuGetV0", "NuGetCommandV2", "NuGetAuthenticateV1", "NuGetInstallerV0", "NuGetPublisherV0", "NuGetRestoreV1", "NuGetToolInstallerV0", "NuGetToolInstallerV1", "PipAuthenticateV0", "PipAuthenticateV1", "TwineAuthenticateV0", "TwineAuthenticateV1", "UniversalPackagesV0"
@phil-hodgson @zhenghao104, @embetten, Here's the node20 migration PR including artifact packages tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do some of the _buildConfig/Node20 folders have tests and some do not ? Is this intentional?
It depends on the tasks, if there's node20 test files changes in |
@embetten @merlynomsft Could you please review it again and sign it off? I'm not sure if Emily has access to the repo and able to give approval for this PR? |
Task name: 21 tasks owned by artifact packages.
"CargoAuthenticateV0","CondaAuthenticateV0","DownloadPackageV0", "DownloadPackageV1",
"MavenAuthenticateV0","NpmV0", "NpmV1", "NpmAuthenticateV0","NuGetV0", "NuGetCommandV2",
"NuGetAuthenticateV1", "NuGetInstallerV0","NuGetPublisherV0","NuGetRestoreV1", "NuGetToolInstallerV0",
"NuGetToolInstallerV1", "PipAuthenticateV0", "PipAuthenticateV1","TwineAuthenticateV0","TwineAuthenticateV1",
"UniversalPackagesV0"
Description: Migrate 21 tasks owned by artifact packages using new build config Node20_229_1
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist: