Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 21 artifact package tasks to Node20 #19101

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

qianz2
Copy link
Contributor

@qianz2 qianz2 commented Oct 12, 2023

Task name: 21 tasks owned by artifact packages.

"CargoAuthenticateV0","CondaAuthenticateV0","DownloadPackageV0", "DownloadPackageV1",
"MavenAuthenticateV0","NpmV0", "NpmV1", "NpmAuthenticateV0","NuGetV0", "NuGetCommandV2",
"NuGetAuthenticateV1", "NuGetInstallerV0","NuGetPublisherV0","NuGetRestoreV1", "NuGetToolInstallerV0",
"NuGetToolInstallerV1", "PipAuthenticateV0", "PipAuthenticateV1","TwineAuthenticateV0","TwineAuthenticateV1",
"UniversalPackagesV0"

Description: Migrate 21 tasks owned by artifact packages using new build config Node20_229_1

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

"CargoAuthenticateV0",
        "CondaAuthenticateV0",
        "DownloadPackageV0",
        "DownloadPackageV1",
        "MavenAuthenticateV0",
        "NpmV0",
        "NpmV1",
        "NpmAuthenticateV0",
        "NuGetV0",
        "NuGetCommandV2",
        "NuGetAuthenticateV1",
        "NuGetInstallerV0",
        "NuGetPublisherV0",
        "NuGetRestoreV1",
        "NuGetToolInstallerV0",
        "NuGetToolInstallerV1",
        "PipAuthenticateV0",
        "PipAuthenticateV1",
        "TwineAuthenticateV0",
        "TwineAuthenticateV1",
        "UniversalPackagesV0"
@qianz2 qianz2 requested a review from a team as a code owner October 12, 2023 00:43
@qianz2
Copy link
Contributor Author

qianz2 commented Oct 12, 2023

@phil-hodgson @zhenghao104, @embetten, Here's the node20 migration PR including artifact packages tasks.

Copy link
Contributor

@embetten embetten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do some of the _buildConfig/Node20 folders have tests and some do not ? Is this intentional?

@qianz2
Copy link
Contributor Author

qianz2 commented Oct 17, 2023

Why do some of the _buildConfig/Node20 folders have tests and some do not ? Is this intentional?

It depends on the tasks, if there's node20 test files changes in Tests/, then they'll be included in _buildConfigs/Node20. Files under _buildConfigs/Node20 folder will replace files in base tasks when generating node20 tasks.

@qianz2
Copy link
Contributor Author

qianz2 commented Oct 17, 2023

@embetten @merlynomsft Could you please review it again and sign it off? I'm not sure if Emily has access to the repo and able to give approval for this PR?

@qianz2 qianz2 merged commit ebb3247 into master Oct 17, 2023
8 checks passed
@qianz2 qianz2 deleted the user/zqian/migrate-artifact-package-tasks branch October 17, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants