Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureSpringCloudV0] Print app logs when deployment failed #19096

Closed
wants to merge 5 commits into from

Conversation

RuoyuWang-MS
Copy link
Member

Task name:
AzureSpringCloudV0

Description:
When deployment failed, we will print app logs to the screen for the customer to dignose.

Documentation changes required: (Y/N)
N
Added unit tests: (Y/N)
N
Attached related issue: (Y/N)
Customer reached us by icm.

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@RuoyuWang-MS RuoyuWang-MS changed the title Print app logs when deployment failed [AzureSpringCloudV0] Print app logs when deployment failed Oct 11, 2023
@RuoyuWang-MS
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 19096 in repo microsoft/azure-pipelines-tasks

@RuoyuWang-MS
Copy link
Member Author

I tried to bump version to 0.230.0 but after running node make.js build --task AzureSpringCloudV0 it come back to 0.229.x automatically.

@RuoyuWang-MS
Copy link
Member Author

@mmrazik @DmitriiBobreshev Would you please help review this PR at your convenience? Thanks a lot!

@RuoyuWang-MS
Copy link
Member Author

This PR have some dirty code changes in the dirty changes in _generated and Node16 folder
I rebase the latest code base and reopen one PR without the dirty changes: #19153
Please help review the latest one! Thanks a lot!

"Minor": 227,
"Patch": 1
"Minor": 230,
"Patch": 2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this Patch version be 0? Because we advanced the Minor version and this is the first build of this minor version.

"Minor": 227,
"Patch": 1
"Minor": 230,
"Patch": 2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants