Migrate 14 node20 Tasks #19063
Merged
Migrate 14 node20 Tasks #19063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlynomsft
reviewed
Oct 6, 2023
qianz2
changed the title
merlynomsft
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Setting to 'request changed' based on discussion. Bumping the base versions should unblock tasks w/preprocessor. Example: #19085
Updated |
merlynomsft
approved these changes
Oct 9, 2023
qianz2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name:
"FtpUploadV2",
"MSBuildV1",
"NodeToolV0",
"PowerShellV2",
"PythonScriptV0",
"ShellScriptV2",
"SshV0",
"UseNodeV1",
"XcodeV5",
"InstallAppleCertificateV2",
"InstallAppleProvisioningProfileV1",
"InstallSSHKeyV0",
"JavaToolInstallerV0",
"JenkinsQueueJobV2"
Description: Migrate rest of tasks owned by Akvelon team. Applied BuildConfigGen changes to avoid bumping up base tasks.
In order to eliminate the default tasks in _generated folder, we're going to build base tasks under Task folder. However, there're preprocessors in typescript or javascript files that would need to be processed and generated before the build.
The solution to resolve it is to generated base tasks on the fly, preprocessing tasks files, build it and then remove it.
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist: