Follow redirects from ADO to stitch content in external service #18987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboom
force-pushed
the
users/ggurgul/blobsitcher
branch
2 times, most recently
from
443366a to
ed4f1e3
Compare
Prefer redirect Prefer redirect bump version enable for now Prefer redirect Correctly follows redirect Correctly follows redirect Separate 1 golden commit refactor Refactor fix Updates versions
kboom
force-pushed
the
users/ggurgul/blobsitcher
branch
from
ed4f1e3 to
cc13d5b
Compare
kboom
changed the title
manolerazvan
approved these changes
Sep 21, 2023
manolerazvan
approved these changes
Sep 21, 2023
…azure-pipelines-tasks into users/ggurgul/blobsitcher
…azure-pipelines-tasks into users/ggurgul/blobsitcher
starkmsu
approved these changes
Sep 21, 2023
DmitriiBobreshev
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: DownloadBuildArtifacts@V0
Description: Today, there are reasons why many organizations cannot migrate from DownloadBuildArtifacts@V0 to V1. The newer V1 version of the task stitches the downloaded content on the agent worker, while the older V0 does this in the hosted service. This is bad for performance. This PR modifies DownloadBuildArtifacts@V0 to request a redirect link from ADO instead of the streamed content which was already stitched and follow this redirect to download the stitched content from the external service. If this process fails, we fall back to the original behavior, which is to stream the content from TFS.
Although the vast majority of users won't need to do it, the users can disable this behavior by setting the
retryRedirectDownloadCountinput to-1, so we won't even attempt using a redirect.Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist: