Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureRmWebAppDeploymentV3] Update task to node16 using codegen #18919

Conversation

DmitriiBobreshev
Copy link
Contributor

Task name: AzureRmWebAppDeploymentV3

Description:

  • Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec) and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could catch and handle the errors in NuGetInstaller.installNuGet method.
  • Added additional argument wrapper for backward compability

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

- Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec)
  and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could
  catch and handle the errors in NuGetInstaller.installNuGet method.
- Added additional argument wrapper for backward compability
DmitriiBobreshev and others added 2 commits September 5, 2023 12:56
- Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec)
  and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could
  catch and handle the errors in NuGetInstaller.installNuGet method.
- Added additional argument wrapper for backward compability
@kirill-ivlev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev DmitriiBobreshev merged commit cfc97f2 into master Sep 19, 2023
@DmitriiBobreshev DmitriiBobreshev deleted the user/dmitriibobreshev/azurermwebappdeploymentv3_node16_upgrade branch September 19, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants