-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureRmWebAppDeploymentV3] Update task to node16 using codegen #18919
Merged
DmitriiBobreshev
merged 6 commits into
master
from
user/dmitriibobreshev/azurermwebappdeploymentv3_node16_upgrade
Sep 19, 2023
Merged
[AzureRmWebAppDeploymentV3] Update task to node16 using codegen #18919
DmitriiBobreshev
merged 6 commits into
master
from
user/dmitriibobreshev/azurermwebappdeploymentv3_node16_upgrade
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec) and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could catch and handle the errors in NuGetInstaller.installNuGet method. - Added additional argument wrapper for backward compability
- Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec) and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could catch and handle the errors in NuGetInstaller.installNuGet method. - Added additional argument wrapper for backward compability
…entv3_node16_upgrade
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
v-mohithgc
approved these changes
Sep 19, 2023
kirill-ivlev
approved these changes
Sep 19, 2023
Pranshu-Negi
approved these changes
Sep 19, 2023
…entv3_node16_upgrade
DmitriiBobreshev
deleted the
user/dmitriibobreshev/azurermwebappdeploymentv3_node16_upgrade
branch
September 19, 2023 12:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureRmWebAppDeploymentV3
Description:
Documentation changes required: N
Added unit tests: N
Checklist: