[UseDotNetV2] - Fix NuGet incompatibility #18898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced exec with execSync since in node10 the task-lib wasn't catch/failed tasks on async operations (like exec) and from node16 it started to throws errors which can be caught by the task-lib. With execSync the UseDotNet task could catch and handle the errors in NuGetInstaller.installNuGet method.
DmitriiBobreshev
requested review from
rvairavelu and
manolerazvan
as code owners
kirill-ivlev
approved these changes
Aug 30, 2023
max-zaytsev
approved these changes
Aug 30, 2023
Pranshu-Negi
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: UseDotNetV2
Description:
Documentation changes required: N
Added unit tests: N
Checklist: