Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IISWebAppDeploymentOnMachineGroupV0] Migrate to Node 16 with updated webdeployment-common library #18855

Merged

Conversation

aleksandrlevochkin
Copy link
Contributor

@aleksandrlevochkin aleksandrlevochkin commented Aug 22, 2023

Task name: IISWebAppDeploymentOnMachineGroupV0

Description:

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@aleksandrlevochkin aleksandrlevochkin marked this pull request as ready for review August 23, 2023 12:04
@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku v-nagarajku requested a review from a user September 13, 2023 09:26
Copy link
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksandrlevochkin - I have tested the PR and it is working as expected.
image

Test case - I created website from my local IIS server and I was able to deploy the web app from the task and task was succeeded.

@v-nagarajku
Copy link
Contributor

@ozanaydinMSFT - I have tested this PR and could see task got succeeded and my sample web app was deployed to local IIS server. Can you please provide your feedback on this, before merging? Thanks
image

Copy link
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksandrlevochkin aleksandrlevochkin merged commit e8a5680 into master Sep 20, 2023
@DmitriiBobreshev DmitriiBobreshev deleted the users/levochkin/iis-webapp-deployment-v0-migration branch October 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants