Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureSpringCloudV0] Several updates on this task #18555

Merged

Conversation

yitaopan
Copy link
Member

@yitaopan yitaopan commented Jun 26, 2023

Task name: AzureSpringCloudV0

Description: Several updates contained in this PR

  1. Add Java_17 support in the runtime version options and update the help label.
  2. Replace the task helpMarkDown link to the doc of this task but not the doc of this AzureSpringApps service.
  3. Update the logic whether DeploymentName should be required.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@yitaopan yitaopan changed the title [AzureSpringCloudV0] Update the hint for RuntimeVersion to reduce confusion [AzureSpringCloudV0] Several updates on this task Sep 11, 2023
@yitaopan
Copy link
Member Author

Hi, @DmitriiBobreshev, thanks for your review!
Since this PR has been idle for some time, I would like to ask that is this ready to be merged or is there anything else I need to do?

@DmitriiBobreshev
Copy link
Contributor

Hi @yitaopan. Could you please resolve conflicts and bump the patch version?

@yitaopan yitaopan force-pushed the yitao/fix-runtime-version-hint branch from ecb5683 to d070083 Compare October 17, 2023 09:26
@yitaopan
Copy link
Member Author

Hi @yitaopan. Could you please resolve conflicts and bump the patch version?

Oh, sure, I have bumped the task version and resolved the conflicts.

@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Oct 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft microsoft deleted a comment from azure-pipelines bot Oct 20, 2023
@allxiao
Copy link

allxiao commented Oct 24, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18555 in repo microsoft/azure-pipelines-tasks

@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

-- fixed package-lock in checks
@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev DmitriiBobreshev merged commit d812267 into microsoft:master Oct 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants