Fixed resource file not being set when making localized calls in Grad… #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,9 @@ import trm = require('vsts-task-lib/toolrunner'); | |||
| import sqCommon = require('sonarqube-common/sonarqube-common'); | |||
| import {SonarQubeEndpoint} from 'sonarqube-common/sonarqube-common'; | |||
|
|
|||
| // Set up localization resource file | |||
| tl.setResourcePath(path.join( __dirname, 'task.json')); | |||
There was a problem hiding this comment.
Is this necessary ? Isn't it enough to set it once in the GradleTask.ts ?
There was a problem hiding this comment.
Discovered in testing that in fact no, it's not.
|
LGTM |
HSAR
added a commit
that referenced
this pull request
Jun 7, 2016
HSAR
added a commit
that referenced
this pull request
Jun 7, 2016
…le (#1848) * Fixed resource file not being set when making localized calls in Gradle build. (#1843) Added no-warning assertions to some Maven and Gradle tests. (#1847) (cherry picked from commit f5b958c) (cherry picked from commit 597033c) Bumped version numbers * Roll back Gradle patch number. (Avoids losing work done after m101 cutoff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le build.