Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made project parameters mandatory in code for SonarQube analysis in G… #1814

Merged
merged 1 commit into from
May 31, 2016

Conversation

HSAR
Copy link
Contributor

@HSAR HSAR commented May 31, 2016

…radle build.

@msftclas
Copy link

Hi @HSAR, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@HSAR
Copy link
Contributor Author

HSAR commented May 31, 2016

Diff has failed slightly - in the tests the following has changed:

  • The test case for ordinary analysis now specifies the project name, key and version (and checks for the same).
  • The test case for analysis on an older version of SonarQube now specifies the project name, key and version (and checks for the same).
  • The test case for analysis with a specified name, key and version has been deleted as it has merged into the first two.

@bgavrilMS
Copy link
Member

LGTM

@HSAR HSAR merged commit 99d2107 into master May 31, 2016
@HSAR HSAR deleted the users/sschen/gradle_sq branch May 31, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants