Enable code coverage for ant, maven and gradle #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tr.setInput('javaHomeSelection', 'JDKVersion'); | ||
| tr.setInput('jdkVersion', 'default'); | ||
| tr.setInput('testResultsFiles', '**/TEST-*.xml'); | ||
| tr.setInput('codeCoverageTool', 'Cobertura'); |
| @@ -1,15 +1,18 @@ | |||
| /// <reference path="../../definitions/vsts-task-lib.d.ts" /> | |||
|
|
|||
| import tl = require('vsts-task-lib/task'); | |||
| var sourceDirectories = tl.getInput('srcDirectories'); | ||
| // appending with small guid to keep it unique. Avoiding full guid to ensure no long path issues. | ||
| var reportDirectoryName = "CCReport43F6D5EF"; | ||
| reportDirectory = path.join(buildRootPath, reportDirectoryName); |
There was a problem hiding this comment.
explained offline
| }, | ||
| "gradlew properties": { | ||
| "code": 0, | ||
| "stdout": "Something subprojects", |
| var reportPOMFile = null; | ||
| var execFileJacoco = null; | ||
| var ccReportTask = null; | ||
| enableCodeCoverage(); |
There was a problem hiding this comment.
Can you add type information to the above vars?
var summaryFile: string = null;
| } | ||
| } | ||
|
|
||
| function isFileExists(path: string) { |
There was a problem hiding this comment.
For clarity, this method should be named pathExistsAsFile().
|
Thank you for adding the L0 tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing : unit tests, Manual testing. Ran all e2e tests against coreclr agent .