Maven: Respect M2_HOME env variable in TypeScript version #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'Default', first look for Maven in the M2_HOME env var path. If not found there, look in the system path.
| m2HomeEnvVar = tl.getVariable('M2_HOME'); | ||
| if (m2HomeEnvVar) { | ||
| tl.debug('Using M2_HOME environment variable value for Maven path: ' + m2HomeEnvVar); | ||
| mvnExec = path.join(m2HomeEnvVar, 'bin/mvn'); |
There was a problem hiding this comment.
path.join(m2HomeEnvVar, 'bin', 'mvn')
The slash is OS dependent, should avoid it.
| @@ -0,0 +1,68 @@ | |||
| { | |||
| "exec": { | |||
There was a problem hiding this comment.
This response file only needs the "exec" commands that you are making for the test that uses it. You can remove the rest. This will help make sure we don't change something incorrectly and the test will still pass unexpectedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Maven TypeScript version. Also, when Maven version is set to 'Default', first look for Maven in the M2_HOME env var path. If not found there, look in the system path.