Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert gulp --no-color #1717

Merged
merged 1 commit into from
May 12, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Tasks/Gulp/gulptask.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ if(!tl.exist(gulp)) {
}
else {
var gt = tl.createToolRunner(gulp);
gt.arg('--no-color');
}

// optional - no targets will concat nothing
Expand Down
4 changes: 2 additions & 2 deletions Tests/L0/Gulp/_suite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Gulp Suite', function() {
tr.setInput('gulpjs', 'node_modules/gulp/gulp.js');
tr.run()
.then(() => {
assert(tr.ran('/usr/local/bin/gulp --no-color --gulpfile gulpfile.js'), 'it should have run Gulp');
assert(tr.ran('/usr/local/bin/gulp --gulpfile gulpfile.js'), 'it should have run Gulp');
assert(tr.invokedToolCount == 1, 'should have only run Gulp');

assert(tr.stderr.length == 0, 'should not have written to stderr');
Expand Down Expand Up @@ -223,7 +223,7 @@ describe('Gulp Suite', function() {
tr.setInput('gulpjs', 'node_modules/gulp/gulp.js');
tr.run()
.then(() => {
assert(tr.ran('/usr/local/bin/gulp --no-color --gulpfile gulpfile.js'), 'it should have run gulp');
assert(tr.ran('/usr/local/bin/gulp --gulpfile gulpfile.js'), 'it should have run gulp');
assert(tr.invokedToolCount == 1, 'should have only run gulp');

// success scripts don't necessarily set a result
Expand Down
2 changes: 1 addition & 1 deletion Tests/L0/Gulp/gulpFails.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"gulp": "/usr/local/bin/gulp"
},
"exec": {
"/usr/local/bin/gulp --no-color --gulpfile gulpfile.js": {
"/usr/local/bin/gulp --gulpfile gulpfile.js": {
"code": 1,
"stdout": "gulp output here",
"stderr": "gulp failed with this output"
Expand Down
2 changes: 1 addition & 1 deletion Tests/L0/Gulp/gulpGlobalGood.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"gulp": "/usr/local/bin/gulp"
},
"exec": {
"/usr/local/bin/gulp --no-color --gulpfile gulpfile.js": {
"/usr/local/bin/gulp --gulpfile gulpfile.js": {
"code": 0,
"stdout": "gulp output here"
}
Expand Down