Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SshV0 task vulnerabilities #16422

Merged

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Jun 6, 2022

Task name: ShhV0

Description: Updated ssh2 & ssh2-sftp-client packages to fix vulnerabilities

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - runned unit tests locally, it needs to smoke test

Risks analysis checklist:

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

TestCases:

  • Used command "node make.js test --task SshV0 " all tests passed
  • Used azure-pipelines-canary test for ssh task

Unit tests results:
SshV0UnitTestOutput.txt

@KonstantinTyukalov KonstantinTyukalov requested a review from a team as a code owner June 6, 2022 15:56
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Could you also share information about the testing done?

@Kozlov-Igor
Copy link
Contributor

Tested successfully with self-hosted agent and containerized SSH server in Windows 10.

@DmitriiBobreshev DmitriiBobreshev merged commit 68c1642 into master Jun 24, 2022
@DmitriiBobreshev DmitriiBobreshev deleted the users/KonstantinTyukalov/fix_sshv0_vulnerabilities branch June 24, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants