Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CocoaPodV0]: Add proxy support #16169

Merged
merged 38 commits into from
Jun 17, 2022
Merged

[CocoaPodV0]: Add proxy support #16169

merged 38 commits into from
Jun 17, 2022

Conversation

kirill-ivlev
Copy link
Contributor

@kirill-ivlev kirill-ivlev commented Apr 20, 2022

Task name: CocoaPodV0

Description: Added proxy support for CocoaPod util to fetch packages & repos with proxy if it enabled in the Agent

Documentation changes required: N

Added unit tests: Y

Attached related issue: #12187

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@kirill-ivlev kirill-ivlev requested a review from a team as a code owner April 20, 2022 13:50
@ghost
Copy link

ghost commented Apr 20, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please take a look at the suggestions below.

Tasks/CocoaPodsV0/cocoapods.ts Outdated Show resolved Hide resolved
Tasks/CocoaPodsV0/task.json Outdated Show resolved Hide resolved
Tasks/CocoaPodsV0/task.json Outdated Show resolved Hide resolved
@KonstantinTyukalov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@kirill-ivlev kirill-ivlev changed the title CocoaPodV0: Add proxy support WIP: [CocoaPodV0]: Add proxy support Apr 27, 2022
@kirill-ivlev kirill-ivlev changed the title WIP: [CocoaPodV0]: Add proxy support [CocoaPodV0]: Add proxy support May 31, 2022
@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@kirill-ivlev
Copy link
Contributor Author

@mmrazik could you please review MR?

@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@kirill-ivlev
Copy link
Contributor Author

@mmrazik could you please review this PR?

@kirill-ivlev kirill-ivlev merged commit ecc3212 into microsoft:master Jun 17, 2022
@kirill-ivlev kirill-ivlev deleted the users/kirill-ivlev/fix_cocoapods_ignores_proxy_config branch June 17, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants