-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CocoaPodV0]: Add proxy support #16169
Merged
kirill-ivlev
merged 38 commits into
microsoft:master
from
kirill-ivlev:users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
Jun 17, 2022
Merged
[CocoaPodV0]: Add proxy support #16169
kirill-ivlev
merged 38 commits into
microsoft:master
from
kirill-ivlev:users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/kirill-ivlev/azure-pipelines-tasks into users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and please take a look at the suggestions below.
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Co-authored-by: Alexander Smolyakov <[email protected]>
Co-authored-by: Alexander Smolyakov <[email protected]>
https://github.com/kirill-ivlev/azure-pipelines-tasks into users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
kirill-ivlev
changed the title
CocoaPodV0: Add proxy support
WIP: [CocoaPodV0]: Add proxy support
Apr 27, 2022
…_ignores_proxy_config
https://github.com/kirill-ivlev/azure-pipelines-tasks into users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
kirill-ivlev
changed the title
WIP: [CocoaPodV0]: Add proxy support
[CocoaPodV0]: Add proxy support
May 31, 2022
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
https://github.com/kirill-ivlev/azure-pipelines-tasks into users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
https://github.com/kirill-ivlev/azure-pipelines-tasks into users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
@mmrazik could you please review MR? |
alexander-smolyakov
approved these changes
Jun 13, 2022
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
vmapetr
approved these changes
Jun 13, 2022
@mmrazik could you please review this PR? |
mmrazik
approved these changes
Jun 15, 2022
mmrazik
reviewed
Jun 15, 2022
kirill-ivlev
deleted the
users/kirill-ivlev/fix_cocoapods_ignores_proxy_config
branch
June 17, 2022 06:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: CocoaPodV0
Description: Added proxy support for CocoaPod util to fetch packages & repos with proxy if it enabled in the Agent
Documentation changes required: N
Added unit tests: Y
Attached related issue: #12187
Checklist: