Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cred provider and add new NuGetAuthenticate major version #15993

Closed
wants to merge 9 commits into from
Closed

Update cred provider and add new NuGetAuthenticate major version #15993

wants to merge 9 commits into from

Conversation

satbai
Copy link
Contributor

@satbai satbai commented Mar 7, 2022 •
edited
Loading

Task name: NuGetAuthenticateV0, NuGetAuthenticateV1

Description: Update cred provider to 1.0.0 and bump major version

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@satbai satbai force-pushed the users/satbai/cpUpdate branch from 6a5997b to 5e9215c Compare March 15, 2022 09:28
@satbai satbai changed the title Update NuGetAuthenticate cred provider to 1.0.0 and add net6 support Update cred provider and add new NuGetAuthenticate major version Mar 15, 2022
@shadargee1982
Copy link
Contributor

shadargee1982 commented Mar 21, 2022 •
edited
Loading

Worth noting that depreceting NugetAuthenticateV0 will require updates to that task's documentation to call out that there is a NugetAuthenticateV1.

Also, need to update Task Owners doc for NugetAuthenticateV1

shadargee1982
shadargee1982 requested changes Mar 21, 2022
View reviewed changes
Tasks/NuGetAuthenticateV1/main.ts Outdated Show resolved Hide resolved
@satbai
Copy link
Contributor Author

satbai commented Mar 22, 2022

@shadargee1982 Here's the doc changes: https://github.com/MicrosoftDocs/azure-devops-docs-pr/pull/4462
Also changes to canary tests: https://github.com/microsoft/azure-pipelines-canary/pull/744

@satbai
Copy link
Contributor Author

satbai commented Mar 23, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

This was referenced Mar 23, 2022
Merged
Merged
@satbai satbai closed this Mar 23, 2022
@satbai
Copy link
Contributor Author

satbai commented Mar 23, 2022

This PR must go in in two separate PRs:
changes to packaging-common: #16065
changes to NuGet Authenticate: #16066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embetten embetten embetten approved these changes

@shadargee1982 shadargee1982 shadargee1982 approved these changes

@phil-hodgson phil-hodgson Awaiting requested review from phil-hodgson

@aasim aasim Awaiting requested review from aasim

Assignees

@shadargee1982 shadargee1982

@embetten embetten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satbai @shadargee1982 @embetten