-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vulnerabilities #15896
Merged
Merged
Fix vulnerabilities #15896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should be updated with the codecoverage-tools common package dependencies update
anatolybolshakov
approved these changes
Feb 14, 2022
All tests successfully passed: https://dev.azure.com/v-dshmelev/playground/_build/results?buildId=1873 |
mr-dokara
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mr-dokara
reviewed
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: root of the repo, ANTV1, AndroidSigningV2, AndroidSigningV3, ArchiveFilesV2, BashV3, CMakeV1, CUrlUploaderV2, CmdLineV2, CocoaPodsV0, DecryptFileV1, CopyFilesOverSSHV0
Description:
Root:
mocha-junit-reporter
.mocha-junit-reporter
traces frommake.js
.markdown-toc
.mocha
to 5.x to resolve most vulnerabilities. There's still one remaining for this package -mocha > mkdirp > minimist
. All dependencies are fixed only in mocha 9.x, but we can't update to this version until we fully migrate to node 10.make.js
andmake-util.js
to bring dependency usage up to date.ANTV1, AndroidSigningV2, AndroidSigningV3, ArchiveFilesV2, BashV3, CMakeV1, CUrlUploaderV2, CmdLineV2, CocoaPodsV0, DecryptFileV1
path-parse
.path-parse
changed.CopyFilesOverSSHV0
ssh2
package version. This is a major version bump, so rigorous testing is needed.ssh2-sftp-client
too because ofssh2
update.Documentation changes required: No
Added unit tests: No
Checklist: