Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DownloadFileshareArtifactsV0 task to Node10 #15840

Conversation

mr-dokara
Copy link
Contributor

@mr-dokara mr-dokara commented Jan 28, 2022

Task name: DownloadFileshareArtifactsV0

Description: Migrated DownloadFileshareArtifactsV0 task to Node10

  • Execution handler is updated
  • Typings are deleted

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

Test results:

@mr-dokara mr-dokara requested a review from harshiniks as a code owner January 28, 2022 11:30
@mr-dokara mr-dokara requested a review from a team January 28, 2022 11:34
@harshiniks
Copy link
Contributor

should I merge this?

@anatolybolshakov
Copy link
Contributor

@harshiniks would it be possible for you to test these changes also - to make sure that it's all fine? We've tested it for some simple scenarios, but it would be great to check on some more complex cases.

@harshiniks
Copy link
Contributor

@harshiniks would it be possible for you to test these changes also - to make sure that it's all fine? We've tested it for some simple scenarios, but it would be great to check on some more complex cases.

@v-nmursapall please do this and confirm when I should merge

@mr-dokara
Copy link
Contributor Author

cc @geekzter for visibility

@v-nmursapall
Copy link
Contributor

Did a round of testing, looks good to me.

@mr-dokara mr-dokara merged commit b472bfe into master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants