Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecoverage-tools package version in tasks that use it #15830

Conversation

mr-dokara
Copy link
Contributor

@mr-dokara mr-dokara commented Jan 26, 2022

Task name: ANTV1, GradleV2, GradleV3, MavenV2, MavenV3, PublishCodeCoverageResultsV1

Description: Updated codecoverage-tools package version in tasks that use it.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

Test results (using canary tests):

@mr-dokara mr-dokara requested review from ganesp, nadesu and a team as code owners January 26, 2022 13:17
@EzzhevNikita
Copy link
Contributor

EzzhevNikita commented Jan 27, 2022

@golubev-ivan Have you tested these tasks after updating them? Could you please share test cases that you have checked and test results?

@anatolybolshakov
Copy link
Contributor

@golubev-ivan LGTM, but as Nikita said - please make sure that we've properly tested these tasks and described checked cases. You can also use scenarios covered in e2e tests for these tasks.

@mr-dokara
Copy link
Contributor Author

I've tested the tasks after the update using the standard L0 and canary tests. I've shared test results in the description of this PR. Also, I've tried to manually test some tasks, but I couldn't to test them all.

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mr-dokara mr-dokara merged commit eef1507 into master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants