Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DownloadBuildArtifactsV0] Fix security issues #15794

Merged
6 commits merged into from
Jan 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2022

Task name: DownloadBuildArtifactsV0

Description: Update version of artifact-engine to latest one which fixed 7 critical security errors

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #15778

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Tatyana Kostromskaya (Akvelon) added 2 commits January 19, 2022 12:40
@ghost ghost requested a review from harshiniks as a code owner January 19, 2022 12:42
@ghost ghost self-requested a review January 19, 2022 12:42
@anatolybolshakov
Copy link
Contributor

@tatyana-kostromskaya could you please describe test cases checked?

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks!

@ghost
Copy link
Author

ghost commented Jan 21, 2022

@tatyana-kostromskaya could you please describe test cases checked?

I tested this task on full canary scenario: on different platforms download artifacts with different options

@ghost ghost merged commit 5eafac9 into master Jan 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants