-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for bicep files in AzureResourceManagerTemplateDeploymentV3 #15788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor wording suggestions.
Co-authored-by: John Downs <[email protected]>
Co-authored-by: John Downs <[email protected]>
Co-authored-by: John Downs <[email protected]>
Co-authored-by: John Downs <[email protected]>
….com/microsoft/azure-pipelines-tasks into users/t-dedah/addedSupportForBicepv1
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments! I'm reviewing from a 'does this invoke Bicep in the correct way?' perspective, so I'm not looking at code style/maintainability - I'd expect that review to come from someone on your team.
Tasks/AzureResourceManagerTemplateDeploymentV3/operations/Utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this much-desired functionality! The Bicep invocation logic & tests look good to me. I've not really reviewed for code style & maintainability - I expect that review to come from one of the owners of this repo.
Task name: AzureResourceManagerTemplateDeploymentV3
Description: Added support for biceps files in case of "Linked artifact" templateLocation. Local bicep file is converted into a json file using
az bicep build --file <filepath>
which is used for further deployment.As bicep was added in azure cli 2.20.0, any agent using version less than 2.20.0 will not be able to deploy bicep files. Installation step for bicep CLI can be added later.
Documentation changes required: Y
Added unit tests: Y
Attached related issue: Y - #15337
Checklist: