Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for bicep files in AzureResourceManagerTemplateDeploymentV3 #15788

Merged
merged 21 commits into from
Feb 1, 2022

Conversation

t-dedah
Copy link
Contributor

@t-dedah t-dedah commented Jan 17, 2022

Task name: AzureResourceManagerTemplateDeploymentV3

Description: Added support for biceps files in case of "Linked artifact" templateLocation. Local bicep file is converted into a json file using az bicep build --file <filepath> which is used for further deployment.
As bicep was added in azure cli 2.20.0, any agent using version less than 2.20.0 will not be able to deploy bicep files. Installation step for bicep CLI can be added later.

Documentation changes required: Y

Added unit tests: Y

Attached related issue: Y - #15337

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Copy link
Contributor

@johndowns johndowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor wording suggestions.

Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Outdated Show resolved Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Outdated Show resolved Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/task.json Outdated Show resolved Hide resolved
Tasks/AzureResourceManagerTemplateDeploymentV3/README.md Outdated Show resolved Hide resolved
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments! I'm reviewing from a 'does this invoke Bicep in the correct way?' perspective, so I'm not looking at code style/maintainability - I'd expect that review to come from someone on your team.

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this much-desired functionality! The Bicep invocation logic & tests look good to me. I've not really reviewed for code style & maintainability - I expect that review to come from one of the owners of this repo.

@rajnish-byte rajnish-byte self-requested a review February 1, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants