AppCenterDistributeV3: Use newer version of the "appcenter-file-upload-client-node" #15604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-client-node" package which contains content-type declaration for aab files
lucen-ms
approved these changes
Dec 14, 2021
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
… appcenter-file-upload-client-node and it's dependencies in hopes of fixing the Azure pipeline
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15604 in repo microsoft/azure-pipelines-tasks |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
…/node --save-dev"
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
… in internal packages which are fine
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15604 in repo microsoft/azure-pipelines-tasks |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
lucen-ms
requested changes
Jan 3, 2022
lucen-ms
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AppCenterDistributeV3
Description: Increase the version used of package "appcenter-file-upload-client-node" to version that already has content-type for aab. This is a needed fix for aab distribution in AppCenter.
Also add "skipLibCheck" to our task's tsconfig, as that's the setup that we also use in appcenter-cli and without it, we would be getting TS errors for our internal appcenter-file-upload-client-node package, probably because of many conflicting package versions, such as of TS, node, npm, ... between the packages.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N/A
Checklist: