Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XcodeV5] Add Xcode ver. 13 support #15602

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Dec 14, 2021

Task name: XcodeV5

Description:

  • Add Xcode 13 to list of supported versions
  • Update task version
  • Update release notes description

Documentation changes required: (Y/N) Yes

Added unit tests: (Y/N) No

Attached related issue: #15535

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@KonstantinTyukalov KonstantinTyukalov requested a review from a team as a code owner December 14, 2021 11:14
@ghost
Copy link

ghost commented Dec 14, 2021

CLA assistant check
All CLA requirements met.

@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@alexander-smolyakov
Copy link
Contributor

Tested related changes manually all works as expected. Link to the test build: Run 20211214.4

Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexander-smolyakov alexander-smolyakov requested a review from a team December 14, 2021 15:44
@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@bsbechtel
Copy link

Hi, I was curious if this PR adds support for Xcode 13.2.1, which uses the most recent version of the log4j library: https://developer.apple.com/documentation/xcode-release-notes/xcode-13_2_1-release-notes

I am seeing errors in my own pipeline when I try to specify Xcode version 13.2.1, but it may be a separate issue. Thanks

@alexander-smolyakov
Copy link
Contributor

Hi @bsbechtel, this PR provided an ability to pick up the Xcode 13.0 only. As I can see the Xcode 13.2.1 is already presented in the macOS-11 image. To use this version of the Xcode, you have to switch to the macOS-11 image, set the xcodeVersion in the Xcode task as specifyPath, and set xcodeDeveloperDir as '/Applications/Xcode_13.2.1.app' as a result, the Xcode task will pick up Xcode 13.2.1 to build the app.

Here is a YAML snippet for reference:

- task: Xcode@5
  inputs:
    actions: 'build'
    sdk: 'iphoneos'
    xcodeVersion: 'specifyPath'
    xcodeDeveloperDir: '/Applications/Xcode_13.2.1.app'
    packageApp: false

@bsbechtel
Copy link

@alexander-smolyakov thank you for the clarification. Interestingly enough, I ran the pipeline last night using macOS-latest and xcodeVersion: 13, and it used 13.2.1. My understanding is that the macOS-latest image is still pointing to macOS-10.15. For our needs, I'm not complaining, but it was unexpected. Appreciate your quick response.

@alexander-smolyakov
Copy link
Contributor

@bsbechtel it seems the migration process for the macOS-latest label is still in progress, you can track it in the following issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants