AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857 #15252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2021 15:48
…provides on AppSettings is fixes
|
|
PhilipsonJoseph
changed the title
PhilipsonJoseph
changed the title
| @@ -48,8 +49,10 @@ export class AzureFunctionOnContainerDeploymentProvider{ | |||
|
|
|||
| let containerDeploymentUtility: ContainerBasedDeploymentUtility = new ContainerBasedDeploymentUtility(this.appService); | |||
| await containerDeploymentUtility.deployWebAppImage(this.taskParams); | |||
|
|
|||
| this.taskParams.AppSettings = this.taskParams.AppSettings ? this.taskParams.AppSettings.trim() + " " + linuxFunctionStorageSetting : linuxFunctionStorageSetting; | |||
| const linuxFunctionStorageSetting: string = `${linuxFunctionStorageSettingName} ${linuxFunctionStorageSettingValue}`; | |||
There was a problem hiding this comment.
suggestion: You can set value of linuxFunctionStorageSetting based on this.taskParams.AppSettings.indexOf(linuxFunctionStorageSettingName) < 0
const linuxFunctionStorageSetting: string = '';
if (this.taskParams.AppSettings.indexOf(linuxFunctionStorageSettingName) < 0) {
linuxFunctionStorageSetting = `${linuxFunctionStorageSettingName} ${linuxFunctionStorageSettingValue}`;
}There was a problem hiding this comment.
@AmrutaKawade As suggested Changed the code to set linuxFunctionStorageSetting based on condition
AmrutaKawade
approved these changes
Sep 21, 2021
chshrikh
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…provides on AppSettings is fixes
Task name: AzureFunctionAppContainerV1
Description: When user tries to set website enable app service storage in app setting is failed due to default setting on code. now it was changed to check if the default setting is overridden by customer. if overridden then we consider that as priority
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: