Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in JavaToolInstallerV0 task #15215

Merged
6 commits merged into from
Aug 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2021

Task name: JavaToolInstallerV0

Description: Update versions of "typed-rest-client", "azure-pipelines-tool-lib", "azure-pipelines-tasks-utility-common", "azure-pipelines-tasks-azure-arm-rest-v2" packages to the latest which don't have high vulnerability issues

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #15207

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me test also

@anatolybolshakov
Copy link
Contributor

Tested with usage of preinstalled jdk scenario - works fine for me.
For typed-rest-client - this seems to be unused dependency - probably we could remove it.

@anatolybolshakov anatolybolshakov requested a review from a team August 26, 2021 13:48
@ghost
Copy link
Author

ghost commented Aug 26, 2021

Tested with Azure Storage and Local Storage - worked fine

Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes manually, found no issues

@ghost ghost merged commit d316c6a into master Aug 30, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants