Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated arm api version #15168

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Updated arm api version #15168

merged 7 commits into from
Aug 24, 2021

Conversation

vineetmimrot
Copy link
Member

@vineetmimrot vineetmimrot commented Aug 18, 2021

Task name: AzureResourceGroupDeploymentV2,AzureResourceManagerTemplateDeploymentV3

Description: Update arm api version

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@vineetmimrot
Copy link
Member Author

@damccorm I have made changes into common npm package and thus I increased their package version and also increased the version in the task where it is used. But the CI for task is failing as it is unable to find that version as it hasn't been published.

So how is generally this problem solved? Do we need to raise separate PR's for npm package and Task, or since task uses "^1.2.3" version format for npm package, so we just need to bump-up the task version and it will automatically pick-up the latest npm package during publishing of the task.

@bishal-pdMSFT
Copy link
Contributor

AFAIK, @vineetmimrot you will have to first raise PR for common npm packages only. Once that is merged, Danny/ @anatolybolshakov can help us by releasing the new npm module. After that, raise another PR to consume in tasks.

@vineetmimrot vineetmimrot merged commit f6b62fe into master Aug 24, 2021
@vineetmimrot vineetmimrot deleted the users/vimimrot/arm-api branch August 24, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants