AzureKeyVault@1, @2: Fix incorrect inputs properties #15162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohit-batra, @tauhid621 - any chance one of you could review & merge this change? There's been another ask to fix this from users of the VS Code extension. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@rohit-batra, @rvairavelu - could you please take a look at this changes? |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
rohit-batra
approved these changes
Jan 21, 2022
Tasks/AzureKeyVaultV1/task.loc.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 198, | |||
| "Minor": 199, | |||
Tasks/AzureKeyVaultV2/task.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 189, | |||
| "Minor": 199, | |||
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Yay, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureKeyVault@1, AzureKeyVault@2
Description: The
inputsJSON intask.jsonwas usingoptionsinstead ofpropertiesfor the SecretsFilter & RunAsPreJob inputs, leading to incorrect validation downstream in the azure-pipelines-vscode extension.Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Fixes microsoft/azure-pipelines-vscode#410.
Checklist:
This is input validation, so I'm unsure how to test it as I don't know how the schema gets generated.