Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VS 2022 to the VSBuildV1 #15099

Merged
merged 40 commits into from
Aug 17, 2021
Merged

Add support for VS 2022 to the VSBuildV1 #15099

merged 40 commits into from
Aug 17, 2021

Conversation

AnnaOpareva
Copy link
Contributor

@AnnaOpareva AnnaOpareva commented Jul 29, 2021 •
edited
Loading

Task name: VSBuildV1

Description: Add support for VS 2022 to the VSBuildV1

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #15051

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AnnaOpareva AnnaOpareva requested a review from a team July 29, 2021 12:20
@AnnaOpareva AnnaOpareva marked this pull request as draft July 29, 2021 13:13
@AnnaOpareva AnnaOpareva marked this pull request as ready for review August 2, 2021 14:22
@EzzhevNikita
Copy link
Contributor

@AnnaOpareva Please bump msbuildhelpers version in /Tasks/Common/MSBuildHelpers/package.json

alexander-smolyakov
alexander-smolyakov reviewed Aug 6, 2021
View reviewed changes
Tasks/VSBuildV1/Get-VSPath.ps1 Outdated Show resolved Hide resolved
Tasks/VSBuildV1/task.json Outdated Show resolved Hide resolved
Tasks/VSBuildV1/Get-VSPath.ps1 Show resolved Hide resolved
Tasks/VSBuildV1/task.json Outdated Show resolved Hide resolved
@alexander-smolyakov alexander-smolyakov requested a review from a team August 6, 2021 12:17
anatolybolshakov
anatolybolshakov approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EzzhevNikita
Copy link
Contributor

tested this changes manually, found no issues

@AnnaOpareva AnnaOpareva merged commit f3afa15 into master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@alexander-smolyakov alexander-smolyakov Awaiting requested review from alexander-smolyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnaOpareva @EzzhevNikita @anatolybolshakov @alexander-smolyakov