Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the relative source file path when indexing sources in a multi… #15029

Merged
merged 7 commits into from
Sep 17, 2021

Conversation

MarkKharitonov
Copy link
Contributor

…-repo checkout build.

Task name: PublishSymbolsV2

Description: Adjusts the relative path of the indexed source files when multi-repo checkout is used

Documentation changes required: N

Added unit tests: N

Attached related issue: #14852

Checklist:

  • Task version was bumped - done.
  • Tested the code changes offline, since I have no idea how to test an Azure DevOps task.

@ghost
Copy link

ghost commented Jul 9, 2021

CLA assistant check
All CLA requirements met.

@MarkKharitonov
Copy link
Contributor Author

Anyone?

@weikanglim
Copy link

Hey Mark, thanks for submitting this change. We would need to test this in a full build end-to-end with the scenario in mind, and ensure that the new symbols are indexed correctly. I'm a little confused if the TFS_REPO would even be correct in the multi-repo scenario. Fixing the relative source directory is one thing, but the repository might still be incorrect.

@MarkKharitonov
Copy link
Contributor Author

Could you comment on the code itself, so that the context of the comment is clear?

@fadnavistanmay fadnavistanmay removed the request for review from b-barthel September 16, 2021 21:09
@ghost
Copy link

ghost commented Sep 17, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@carl-tanner carl-tanner merged commit 211e544 into microsoft:master Sep 17, 2021
@MarkKharitonov MarkKharitonov deleted the fix14852 branch September 17, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants