Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowershellV2] Fix powershell execution script to fail on wrong targettype #15026

Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2021

Task name: PowershellV2

Description:

  • Add additional condition to validate if target path is 'filepath' or 'inline', otherwise write error
  • Add localization string for error message

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) https://github.com/microsoft/build-task-team/issues/1355

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ghost ghost requested a review from mjroghelia as a code owner July 9, 2021 07:45
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Btw does it mean that there could be the same issue for other task inputs with type: radio and Powershell execution handlers? If so - could it make sense to recheck all Powershell handler tasks also?
cc @alexander-smolyakov

@anatolybolshakov anatolybolshakov requested a review from a team July 9, 2021 15:56
@ghost ghost merged commit 5924ffb into master Jul 14, 2021
@ghost ghost deleted the users/tatyana-kostromskaya/fix_1355_PowerShellV2_notFailTargetType branch August 4, 2021 10:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants