Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DownloadBuildArtifactsV0] Add clean up logic of destination folder #15025

Merged
4 commits merged into from
Jul 12, 2021
Merged

[DownloadBuildArtifactsV0] Add clean up logic of destination folder #15025

4 commits merged into from
Jul 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2021 •
edited by ghost
Loading

Task name: DownloadBuildArtifactsV0

Description:

  • Add input option "Clean destination folder" to advanced group
  • Add logic to clean up destination folder in DownloadBuildArtifacts task if option "Clean destination folder" is checked

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: microsoft/azure-pipelines-agent#2711

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Screenshot of added "checkbox":

image

Tatyana Kostromskaya (Akvelon INC) added 2 commits July 8, 2021 10:52
@ghost ghost requested a review from max-zaytsev July 8, 2021 09:42
@ghost ghost requested review from chandrasekharmudili and narula0781 as code owners July 8, 2021 09:42
@ghost
Copy link

ghost commented Jul 8, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@max-zaytsev max-zaytsev requested a review from a team July 8, 2021 12:17
DaniilShmelev
DaniilShmelev approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Let me test this also

@EzzhevNikita EzzhevNikita requested a review from a team July 9, 2021 05:55
alexander-smolyakov
alexander-smolyakov reviewed Jul 9, 2021
View reviewed changes
Tasks/DownloadBuildArtifactsV0/main.ts Outdated Show resolved Hide resolved
Tasks/DownloadBuildArtifactsV0/main.ts Show resolved Hide resolved
Tasks/DownloadBuildArtifactsV0/main.ts Outdated Show resolved Hide resolved
alexander-smolyakov
alexander-smolyakov approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghost ghost merged commit e6aab16 into master Jul 12, 2021
@ghost ghost mentioned this pull request Jul 15, 2021
Merged
@ghost ghost deleted the users/tatyana-kostromskaya/fix_2711_DownloadBuildArtifactsV0_cleanDestFold branch August 4, 2021 10:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandrasekharmudili chandrasekharmudili Awaiting requested review from chandrasekharmudili

@narula0781 narula0781 Awaiting requested review from narula0781

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anatolybolshakov @alexander-smolyakov @max-zaytsev @EzzhevNikita @DaniilShmelev