Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArchiveFilesV2]Change default value for sevenZipCompression option #14919

Conversation

vladislav-ryzhov
Copy link
Contributor

Task name: ArchiveFilesV2

Description: Changed default value for sevenZipCompression option

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) Y

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@vladislav-ryzhov vladislav-ryzhov requested a review from a team June 2, 2021 07:17
Copy link
Contributor

@EzzhevNikita EzzhevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the task version into task.loc.json file?
And I also wanted to clarify on the basis of what did you choose the default value for this parameter?

@EzzhevNikita EzzhevNikita requested a review from a team June 2, 2021 07:33
@vladislav-ryzhov
Copy link
Contributor Author

vladislav-ryzhov commented Jun 2, 2021

@EzzhevNikita

Could you please bump the task version into task.loc.json file?

Yes, corrected it.

And I also wanted to clarify on the basis of what did you choose the default value for this parameter?

Since normal and default values return "5", I think that it is ok if the default value will be equal "normal".
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/ArchiveFilesV2/archivefiles.ts#L135

@EzzhevNikita
Copy link
Contributor

@EzzhevNikita

Could you please bump the task version into task.loc.json file?

Yes, corrected it.

And I also wanted to clarify on the basis of what did you choose the default value for this parameter?

Since normal and default values return "5", I think that it is ok if the default value will be equal "normal".
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/ArchiveFilesV2/archivefiles.ts#L135

A, yeah I got it, in this case, it looks logical

@EzzhevNikita EzzhevNikita requested a review from a team June 2, 2021 07:55
@vladislav-ryzhov vladislav-ryzhov merged commit f3f0c8a into master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants