-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow not to create subdirectory for jdk extraction #14847
Allow not to create subdirectory for jdk extraction #14847
Conversation
…' of https://github.com/microsoft/azure-pipelines-tasks into users/EzzhevNikita/allow_not_to_create_extractdirectory
66f042e
to
47363e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the comments, but other than that LGTM, thanks!
Let me test this manually as well
Tasks/JavaToolInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Task failed with the following error: Repro: - task: JavaToolInstallerM@0
displayName: 'createExtractDirectory=false'
inputs:
versionSpec: 7
jdkArchitectureOption: x64
jdkSourceOption: AzureStorage
azureResourceManagerEndpoint: $(StorageAccountConnection)
azureStorageAccountName: $(StorageAccountName)
azureContainerName: $(AzureContainerName)
azureCommonVirtualFile: $(ArchiveName)
jdkDestinationDirectory: ./tempAzure/java_dir
createExtractDirectory: false |
Yeah thanks, I found this problem too |
Tested these changes manually with azure and local JDK. Found no issues. |
Task name: JavaToolInstallerV0
Description: Added additional input for the task that allows disabling adding additional directory in jdkDestinationDirectory.
Previously when task installed JDk into the directory that looks similar to this like (it created additional directory for JDK inside DestinationDirectory):
jdkDestinationDirectory/JAVA_HOME_8_X64_OpenJDK_zip
In new behavior, by default, we don't change the installation path and it will look in the same format, but we could disable the creation of subdirectory, using createExtractDirectory input.
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #14778
Checklist: