-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker V0 and V1 store build output in temp file #14773
Merged
ajinkya599
merged 6 commits into
microsoft:master
from
jcfiorenzano:users/jcfiorenzano/add-buildoutput-v0-v1
May 5, 2021
Merged
Docker V0 and V1 store build output in temp file #14773
ajinkya599
merged 6 commits into
microsoft:master
from
jcfiorenzano:users/jcfiorenzano/add-buildoutput-v0-v1
May 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfiorenzano
commented
Apr 23, 2021
jcfiorenzano
commented
Apr 23, 2021
ajinkya599
reviewed
May 3, 2021
Hi @ajinkya599 this is the result of this PR running in a pipeline: DockerV0:File content:
DockerV1:File content:
|
ajinkya599
approved these changes
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Tests were failing when run in an agent becuase the path was looking at the wrong path
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Docker
Description: the build command is going to store the output of docker in a temp file and is going to store its path in an output variable
Added unit tests: N
Attached related issue: #14537
Checklist: