[FtpUploadV2] Fail on exception when reading FTP options #14742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniilShmelev
changed the title
DaniilShmelev
force-pushed
the
users/DaniilShmelev/FtpUpload-fail-on-errors
branch
from
e66df32 to
faa4ccf
Compare
anatolybolshakov
approved these changes
Apr 16, 2021
EzzhevNikita
approved these changes
Apr 16, 2021
|
Tested manually this PR. New behavior: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: FtpUploadV2
Description: Fail task when exception is thrown while retrieving FTP options; this issue happens because unhandled promise rejections don't fail the task.
FtpUploadV1 is not affected by this issue because it reads FTP options synchronously.
Documentation changes required: No
Added unit tests: No
Checklist:
Examples:
Old behavior:
✔️FtpUpload@2 valid FTP endpoint
✔️FtpUpload@2 invalid FTP endpoint - doesn't upload anything, but doesn't fail either because unhandledPromiseRejection isn't failing the task
New behavior:
✔️FtpUpload@2 valid FTP endpoint
❌FtpUpload@2 invalid FTP endpoint - fails as expected
FtpUploadV1 (no need to change):
✔️FtpUpload@1 valid FTP endpoint
❌FtpUpload@1 invalid FTP endpoint - fails as expected