Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Utility task for Jmeter test to show proper error message for … #14727

Merged
merged 8 commits into from
Apr 14, 2021

Conversation

anshii03
Copy link
Contributor

@anshii03 anshii03 commented Apr 14, 2021

We want the CLT tasks to fail gracefully with proper error message indicating that the service is now shutdown.

Task name: Apache Jmeter Task

Description: Catching proper error message and displaying so that customer knows that service is now shutdown.

Documentation changes required: N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) [https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1831804]

Logs for cltabc account where cltshutdown is enabled :
image

Logs for clttestsu0 account where cltshutdown is disabled :
image

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@anshii03 anshii03 requested review from ganesp and nadesu as code owners April 14, 2021 05:01
@ganesp
Copy link
Contributor

ganesp commented Apr 14, 2021

@anshii03 The second screenshot shows that the JMeter task not validated completely, it failed to establish the connection with ADO account. Can you please do the needful and update this screenshot after validating scenario (shutdown flag disabled) ?

Copy link
Contributor

@ganesp ganesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shutdown disabled scenario needs to be validated completely.

@anshii03 anshii03 merged commit dfe87e6 into master Apr 14, 2021
@starkmsu starkmsu deleted the anshii03-patch-2 branch July 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants