[DownloadBuildArtifactsV0, JavaToolInstallerV0] Updated OSS dependencies #14703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolybolshakov
approved these changes
Apr 12, 2021
|
LGTM, but let's make buddy testing also - to double-check that it works fine. |
…vatoolinstaller-oss-update
DaniilShmelev
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Tested these changes manually:
DownloadBuildArtifacts:
✔️Storing and not storing permissions, warnings, multiple files download and extraction, windows file share
✔️Downloading file from a different build
✔️Downloading artifact as zip when triggering build via PR from fork
JavaToolInstaller:
✔️Install from local source and azure storage
Found no issues. LGTM!
…vatoolinstaller-oss-update
EzzhevNikita
approved these changes
Apr 14, 2021
added 2 commits
April 14, 2021 16:09
…vatoolinstaller-oss-update
…vatoolinstaller-oss-update
anatolybolshakov
pushed a commit
that referenced
this pull request
May 12, 2021
This reverts commit 392108a.
2 tasks
anatolybolshakov
pushed a commit
that referenced
this pull request
May 12, 2021
This reverts commit 392108a.
anatolybolshakov
pushed a commit
that referenced
this pull request
May 12, 2021
This reverts commit 392108a.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: DownloadBuildArtifactsV0, JavaToolInstallerV0
Description: Updated OSS dependencies
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: