Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GradleV2] Add spotbugs plugin inputs to Gradle task #14625

Merged

Conversation

vladislav-ryzhov
Copy link
Contributor

@vladislav-ryzhov vladislav-ryzhov commented Mar 19, 2021

Task name: GradleV2

Description: Added spotbugsTool instance to gradletask.ts. Added inputs for spotbugs plugin. Changed help markdown for findbugs plugin.

Documentation changes required: Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #13980

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

…in input. Added spotbugsTool instance to gradletask
@max-zaytsev max-zaytsev requested review from a team and removed request for leantk March 19, 2021 10:19
@EzzhevNikita EzzhevNikita requested a review from a team March 19, 2021 10:33
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you please take a look at the comments?
It would be great also to test it once related changes for common package will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants