Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShellV2] Allow to use alternative execution operator #14613

Merged

Conversation

EzzhevNikita
Copy link
Contributor

@EzzhevNikita EzzhevNikita commented Mar 18, 2021

Task name: PowerShellV2

Description: Added optional parameter that allows PowerShell task to execute the script using call operator (&) instead of default dot sourcing operator. This was added to address the issue from feedback ticket

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) feedback ticket

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - Pipeline ref

@EzzhevNikita EzzhevNikita requested a review from a team March 18, 2021 07:19
@anatolybolshakov
Copy link
Contributor

Do we have e2e tests for this case?

@EzzhevNikita
Copy link
Contributor Author

Do we have e2e tests for this case?

For new input there no e2e, but I've created a ticket to add them.

@EzzhevNikita EzzhevNikita requested review from anatolybolshakov and a team March 23, 2021 06:34
@anatolybolshakov anatolybolshakov requested a review from a team March 23, 2021 09:13
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes manually, found no issues

Tasks/PowerShellV2/Tests/L0RunScriptInSeparateScope.ts Outdated Show resolved Hide resolved
Tasks/PowerShellV2/task.json Outdated Show resolved Hide resolved
@anatolybolshakov
Copy link
Contributor

LGTM, thanks! Let's merge it once we have e2e tests for new input and plan this for the near time.

@EzzhevNikita EzzhevNikita merged commit 757abd2 into master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants