Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 10 upgrade for IIS webapp deploy task #14603

Merged
merged 16 commits into from
Apr 7, 2021

Conversation

AmrutaKawade
Copy link
Contributor

@AmrutaKawade AmrutaKawade commented Mar 17, 2021

Task name: IISWebAppDeploymentOnMachineGroupV0

Description: Node10 Upgrade

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@@ -17,7 +17,7 @@
"version": {
"Major": 0,
"Minor": 184,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could it make sense to bump minor version to 185 (current sprint) instead?

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AmrutaKawade AmrutaKawade merged commit aa56a09 into master Apr 7, 2021
@starkmsu starkmsu deleted the Node6hotfixes/IISWebappOnMachineGroup branch July 14, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants