Added secondary location check for pbxProject #14588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
@timothy-volvo thanks for contribution! Could you please bump task version also according to steps? |
|
I am verifying with my org whether I have permission to agree, will respond as soon as I get word |
@timothy-volvo do you have any updates? |
ghost
deleted a comment from
anatolybolshakov
approved these changes
Apr 21, 2021
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@timothy-volvo could you please to sync it with master? I think we are good to merge it after it, thanks! |
|
I have rebased the branch on top of the current master |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: XcodeV5
Description: Adds a fallback check for pbxproj file. The current check looks for a location I have need seen in a Xcode project. I was hesitant to remove as it was coded for a reason, so I added a fall back location should work for most projects
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N, I would, but can't get project to build
Attached related issue: (Y/N) #14577
Checklist: