Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XcodeV5] Fixed issue for post-job when tests results are empty #14527

Merged

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented Mar 3, 2021

Task name: XcodeV5

Description: When tests results are empty for XcodeV5 (for example when main task has been skipped), post-job failed with an error. There is incorrect null check in post-job leading to this issue - so fixed it.

Documentation changes required: N

Added unit tests: added tests to cover case when test results are empty.

Attached related issue: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - checked that there is no failed post-job when main task has been skipped

@anatolybolshakov anatolybolshakov requested a review from a team March 3, 2021 16:15
@anatolybolshakov anatolybolshakov requested a review from leantk as a code owner March 3, 2021 16:15
@anatolybolshakov anatolybolshakov removed the request for review from leantk March 3, 2021 16:45
Copy link
Contributor

@EzzhevNikita EzzhevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump task version?

@EzzhevNikita EzzhevNikita requested a review from a team March 3, 2021 16:52
@anatolybolshakov
Copy link
Contributor Author

Could you please bump task version?

Sure, thanks! Looks like previous bump collided with another one for this task

@EzzhevNikita EzzhevNikita requested a review from a team March 3, 2021 17:42
@anatolybolshakov anatolybolshakov merged commit 3da3b24 into master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants