Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powershell null assignment error #14499

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Fix Powershell null assignment error #14499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b90ad2
Fix Powershell null assignment error
vineetmimrot Mar 2, 2021
f67d6ad
Update task.json
vineetmimrot Mar 2, 2021
360fa7f
Update task.loc.json
vineetmimrot Mar 2, 2021
794f78d
Update task.json
vineetmimrot Mar 2, 2021
c3ecda2
Update task.loc.json
vineetmimrot Mar 2, 2021
a45d1a3
Update task.json
vineetmimrot Mar 2, 2021
57b6321
Update task.loc.json
vineetmimrot Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tasks/Common/ServiceFabricHelpers/Get-ServiceFabricEncryptedText.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function Get-ServerCertThumbprints {
$ClusterConnectionParameters
)

$serverCertThumbprints = null;
$serverCertThumbprints = $null;

if ($ClusterConnectionParameters["ServerCommonName"])
{
Expand Down Expand Up @@ -114,4 +114,4 @@ function Get-ServerCertThumbprints {
}

return $serverCertThumbprints
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricComposeDeployV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 0,
"Minor": 5,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -199,4 +199,4 @@
"InvalidApplicationNameWarning": "Latest Service Fabric has stopped supporting compose application name starting with 'fabric:/' and hence compose deployment might fail with ServiceDnsName error for application name '{0}'. You can provide a different application name and re-run if required.",
"UpgradeInProgress": "An upgrade for the application '{0}' is already in progress."
}
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricComposeDeployV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 0,
"Minor": 5,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -199,4 +199,4 @@
"InvalidApplicationNameWarning": "ms-resource:loc.messages.InvalidApplicationNameWarning",
"UpgradeInProgress": "ms-resource:loc.messages.UpgradeInProgress"
}
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricDeployV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 1,
"Minor": 9,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -481,4 +481,4 @@
"SFSDK_RetryingGetClusterManifest": "Getting cluster manifest..",
"SFSDK_RetryingRemoveApplicationPackage": "Retrying to remove application package.."
}
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricDeployV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 1,
"Minor": 9,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -481,4 +481,4 @@
"SFSDK_RetryingGetClusterManifest": "ms-resource:loc.messages.SFSDK_RetryingGetClusterManifest",
"SFSDK_RetryingRemoveApplicationPackage": "ms-resource:loc.messages.SFSDK_RetryingRemoveApplicationPackage"
}
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricPowerShellV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 1,
"Minor": 2,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -94,4 +94,4 @@
"InvalidScriptArguments0": "Invalid script arguments '{0}'. Line breaks are not allowed.",
"InvalidScriptPath0": "Invalid script path '{0}'. Invalid path characters specified."
}
}
}
4 changes: 2 additions & 2 deletions Tasks/ServiceFabricPowerShellV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 1,
"Minor": 2,
"Patch": 3
"Patch": 4
},
"demands": [
"Cmd"
Expand Down Expand Up @@ -94,4 +94,4 @@
"InvalidScriptArguments0": "ms-resource:loc.messages.InvalidScriptArguments0",
"InvalidScriptPath0": "ms-resource:loc.messages.InvalidScriptPath0"
}
}
}