Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows semicolon fix #14367

Merged
merged 11 commits into from
Feb 10, 2021
Merged

windows semicolon fix #14367

merged 11 commits into from
Feb 10, 2021

Conversation

AmrutaKawade
Copy link
Contributor

@AmrutaKawade AmrutaKawade commented Feb 9, 2021

Task name: AzureMysqlDeploymentV1

Description: Task fails for below combination

Windows Agent + Mysql script file selection
Task fails because of having semi-colon (;) following the MySQL Script file path. converted file path to unix format

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #14352

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@mattboothman
Copy link

This'll work for our use. Just need to consider escape characters in file paths.

Things like /home/my\ home/scripts\ \(mysql\)/ would turn into /home/my/ home/scripts/ /(mysql)/, using regex replace.

@AmrutaKawade
Copy link
Contributor Author

AmrutaKawade commented Feb 10, 2021

This'll work for our use. Just need to consider escape characters in file paths.

Things like /home/my\ home/scripts\ \(mysql\)/ would turn into /home/my/ home/scripts/ /(mysql)/, using regex replace.

No need to escape space or characters, it will fail file search as well. passing path like this will work with file search as well as replace '/home/my home/scripts (mysql)/'

@mattboothman
Copy link

No need to escape space or characters, it will fail file search as well. passing path like this will work with file search as well as replace '/home/my home/scripts (mysql)/'

That's great, I'll pop that into the docs, too. Thanks @AmrutaKawade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants