Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node6hotfixes/azure function app #14189

Merged
merged 31 commits into from
Mar 23, 2021

Conversation

agrataru
Copy link
Contributor

@agrataru agrataru commented Jan 7, 2021

Task name: AzureFunctionAppV1
Description: Adding changes for node 10 changes

  • Updating the package version for node 10
  • Updating the code path to include new path for azurermdeploycommon

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AmrutaKawade AmrutaKawade merged commit 4a8b2c3 into microsoft:master Mar 23, 2021
@ITSTord
Copy link

ITSTord commented Mar 23, 2021

We see a behavior that this task ignores slotName: "value" and deploy it straight to production slot. This worked fine on friday. So our existing pipeline end up with deploy to prod and swap latest code into stage slot... not optimal :)

@ITSTord
Copy link

ITSTord commented Mar 23, 2021

2f764c0#diff-639c038189c01445c7a666c289f267ec6a6c77f7d90046ca6844965ff3bba6eb -> "azure-pipelines-tasks-azurermdeploycommon": "^2.0.3",

@AmrutaKawade
Copy link
Contributor

2f764c0#diff-639c038189c01445c7a666c289f267ec6a6c77f7d90046ca6844965ff3bba6eb

Can you raise issue with logs? This diff is already part of "azure-pipelines-tasks-azurermdeploycommon": "^2.0.3" package

@ITSTord
Copy link

ITSTord commented Mar 23, 2021

#14639 problem were not related to the links above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants